-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add remove_files tests #22
Conversation
Reviewer's Guide by SourceryThis pull request adds tests for the remove_files function in the decryption module. The changes include adding a new pytest fixture for creating temporary files, removing a duplicate fixture definition, and adding a new test class TestRemoveFiles with tests for various scenarios such as removing files, handling empty directories, and non-existent directories. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @athith-g - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 2 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one small comment.
Co-authored-by: Joris Vankerschaver <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are great, but please address the single comment 🙏
Adds tests for remove_files
Summary by Sourcery
This pull request introduces new tests for the
remove_files
function, ensuring its correct behavior in various scenarios including handling empty directories and non-existent directories.remove_files
function to ensure files in a directory are removed successfully.remove_files
.remove_files
.