-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: improve test readability #21
Conversation
Reviewer's Guide by SourceryThis pull request introduces a timeout decorator to the test_tasks.py file. The decorator is used to enforce a time limit on functions, replacing the previous manual timeout checks. The get_task_state and test_task functions have been refactored to use this new decorator, simplifying the code and ensuring consistent timeout handling. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @athith-g - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Also, I think that you'd probably need to rename the PR title ;-) |
Adds a timeout decorator to test_tasks.py and refactors fixtures and test to make them more readable.
Summary by Sourcery
Refactored test_tasks.py to use a timeout decorator for enforcing time limits on task completion and file download functions, improving code readability and maintainability.