-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for get_private_keys #17
Conversation
Reviewer's Guide by SourceryThis pull request adds a new test file File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @athith-g - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hard-coded private key found. (link)
- Hard-coded private key found. (link)
- Hard-coded private key found. (link)
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 3 blocking issues
- 🟡 Testing: 3 issues found
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Adds tests for get_private_keys in decrypt.py.