Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add full support for service info fields #80

Merged
merged 2 commits into from
Nov 5, 2023
Merged

feat: add full support for service info fields #80

merged 2 commits into from
Nov 5, 2023

Conversation

uniqueg
Copy link
Member

@uniqueg uniqueg commented Nov 5, 2023

  • service info schemas and models in full compliance with WES 1.0.1
    • required explicitly setting the base_path with Connexion due to a bug in the specification (services section defines version instead of apiVersion parameter)
    • required explicitly copying the Service Info API schemas Service and ServiceType for the POST /service-info endpoint due to an apparent (undocumented) bug in Connexion or one of the JSON Schema parsers it relies on
  • fix bug introduced in POST /service-info controller in ci: check for code lints with Pylint #76 by readding headers

Fixes #79

@uniqueg uniqueg merged commit f7e8879 into dev Nov 5, 2023
3 checks passed
@uniqueg uniqueg deleted the service_info_api branch November 5, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: add full support for service info fields
1 participant
@uniqueg