Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: social media icon alignment #125

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

AnuragRoshan
Copy link

Before :
Screenshot 2024-02-29 104502

After :
Screenshot 202g4-02-29 104502

Copy link

vercel bot commented Mar 5, 2024

@AnuragRoshan is attempting to deploy a commit to the elixir-cloud-aai Team on Vercel.

A member of the Team first needs to authorize it.

@uniqueg uniqueg changed the title alignment of contributor's social media icons is done style: social media icon alignment Mar 6, 2024
@JaeAeich
Copy link

JaeAeich commented Mar 6, 2024

Hey @AnuragRoshan where are the numbers coming from? If they are the default then it makes sense to add them in tailwindConfig then then use it everywhere like maybe iconHeight or somethings!

PS: Please be sure to use some standard numbers or do some fiddling around to get a reasonable value, because once its in the tailwind config, changing tailwind config can be problematic.

@AnuragRoshan
Copy link
Author

Sure @JaeAeich will do it 😅

Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
landing-page ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 5:48am

@AnuragRoshan
Copy link
Author

Hey @JaeAeich I have added iconHeight in tailwnid.config.js file .

Copy link
Member

@anuragxxd anuragxxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@anuragxxd
Copy link
Member

@JaeAeich please have a look here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants