Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use target platform path separators for asar integrity keys #1781

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

MarshallOfSound
Copy link
Member

After the resedit change cross-building windows on macOS is suddenly a Thing People Can Do so we need to make sure we use windows path separators for the asar integrity manifest when targeting the windows platform.

Fixes #1780

@MarshallOfSound MarshallOfSound requested a review from a team as a code owner November 12, 2024 20:55
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (7024c67) to head (4fe36b1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/platform.ts 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
- Coverage   89.08%   88.66%   -0.42%     
==========================================
  Files          17       17              
  Lines         907      909       +2     
  Branches      187      188       +1     
==========================================
- Hits          808      806       -2     
- Misses         62       64       +2     
- Partials       37       39       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dsanders11 dsanders11 merged commit 6270eeb into main Nov 12, 2024
3 of 5 checks passed
@dsanders11 dsanders11 deleted the fix-asar-integrity-path branch November 12, 2024 22:01
Copy link

🎉 This PR is included in version 18.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASAR integrity info corrupt in crossplatform build
3 participants