Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASAR integrity info corrupt in crossplatform build #1780

Closed
3 tasks done
Lemonexe opened this issue Nov 12, 2024 · 2 comments · Fixed by #1781
Closed
3 tasks done

ASAR integrity info corrupt in crossplatform build #1780

Lemonexe opened this issue Nov 12, 2024 · 2 comments · Fixed by #1781
Labels

Comments

@Lemonexe
Copy link

Preflight Checklist

Electron Version

33.2.0

What operating system(s) are you using?

Ubuntu

Operating System Version

Ubuntu 24.04.1 LTS

What arch are you using?

x64

Last Known Working Electron version

No response

Expected Behavior

  • When building an electron app on Linux for Windows, with EnableEmbeddedAsarIntegrityValidation fuse on, the built .exe binary should contain valid file integrity information.
  • The .exe should start normally.

Actual Behavior

  • The .exe binary built on Linux for Windows contains "file":"resources/app.asar" in the file integrity info
    • instead of the expected "file":"resources\\app.asar".
  • When you execute the binary both natively on Windows, as well as through wine on Linux, crashes with following error:
    [268:1112/144705.795:FATAL:archive_win.cc(152)] Failed to find file integrity info for resources\app.asar
    
  • After switching off the EnableEmbeddedAsarIntegrityValidation fuse on the built binary, the application runs.

Testcase Gist URL

https://gist.github.com/Lemonexe/094a6b77f2ece7b7d326db57ebc75da6

Additional Information

ℹ More details in the gist README.md.

  • The gist is using electron-forge, but I also reproduced it with electron-builder (so I guess issue lies in electron itself).
  • This line throws the error during runtime.
  • I did not find which line is responsible for saving file url with wrong slashes during build (I have no C++ knowledge 😞).
@MarshallOfSound MarshallOfSound transferred this issue from electron/electron Nov 12, 2024
Copy link

welcome bot commented Nov 12, 2024

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

Copy link

🎉 This issue has been resolved in version 18.3.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🛠️ Fixed for Next Release
Development

Successfully merging a pull request may close this issue.

1 participant