Fix Issue 2179 - Installing Playwright on Ubuntu 24 LTS and using Python 3.12 #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is stale as it has been open for 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days. |
| @@ -20,8 +20,8 @@ jobs: | |||
| repo-token: ${{ secrets.GITHUB_TOKEN }} | |||
| stale-issue-message: 'This issue is stale because it has been open 7 days with no activity. Remove stale label or comment, or this will be closed in 10 days.' | |||
| close-issue-message: 'Issue closed due to being stale. Please reopen if issue persists in latest version.' | |||
| days-before-stale: 6 | |||
There was a problem hiding this comment.
lgtm, just rebase your pr so that these changes are not reverted
JasonLovesDoggo
added
before next release
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades Playwright's version to 1.48.0 which supports Ubuntu 24 LTS, and adds Python 3.12 minor version support to
main.py.Issue Fixes
Fixes Issue #2179
Checklist:
Any other information (e.g how to test the changes)
Running a fresh installation on Ubuntu 24.04 LTS will now work, and running the program functions correctly.