fix: address unreliable go dependency caching #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikaverpil
force-pushed
the
go-caching
branch
4 times, most recently
from
1ea35f8
to
0e650ef
Compare
fredrikaverpil
force-pushed
the
go-caching
branch
3 times, most recently
from
3910c42
to
5ecad96
Compare
Due to how you cannot pass in a cache key to actions/go-setup, we cannot reliably use the cache produced by this action. See issue for more info: actions/setup-go#358
This invalidates the cache upon changing _any_ of the go.sum files in the project. This is an optimization change.
fredrikaverpil
force-pushed
the
go-caching
branch
from
5ecad96
to
85692ce
Compare
fredrikaverpil
changed the title
alethenorio
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
This aims to solve the problem where two caches are uploaded (one by
actions/go-setupand one byactions/cache, but where the one fromactions/go-setupwas created by the fastest workflow (with the leastdependencies) and then often used by the slower/heavier workflows. These heavier workflows reuse the cache but it does not contain all dependencies and so it has to re-download and re-build them on every commit. The cache is not rebuilt because there are additional dependencies downloaded.
TL;DR the wrong cache is being used.
The issue is described in detail here: actions/setup-go#358
What was changed?
actions/go-setup.actions/cacheso to also cover Go dependencies and builds. Effectively doing whatactions/go-setupwas supposed to handle.go.sumfiles in the project, not just.sage/go.sum.