-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from cron to pure python #9
Open
debMan
wants to merge
14
commits into
ehcaning:master
Choose a base branch
from
debMan:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+480
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some enhancements
fix: other post types
* docs: Update README to new method with docker * Fix dockerfile
Add photo to messages
* use python-telegram-bot module * create requirements.txt file * change the proxy config in the `.env-sample` file * use the PTB module to connect telegram * change some code styles * use the "ad" model instead of the "house" name with pydantic * remove some redundant functions * fix some indents * fetch multiple images from the ad page and send an album for more than one image * change docker-compose * change the get images method * use the divar API instead of scraping * get the full description * change the extracted data and tokens process * add price to ad details * add emojis in the messages * fix some bugs * save new tokens and old tokens (merge) * ignore the ad if failed to get the data * fix fetch data for empty images
fix: Fix README
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote some changes to migrate from corn to pure Python.
Changes:
.gitignore
and.dockerignore
tokens.json
is mounted directly.cron
and use raw Python and DockerfileSuggestion for further work:
while
loop is not a good choice.