guest: init: default to xterm if TERM is not set (#52)

Most terminal emulators support the xterm control codes more faithfully than the vt100 ones. Fixes #51. Signed-off-by: Ariadne Conill <[email protected]>
edera-dev · Apr 12, 2024 · 73fd95d · 73fd95d
1 parent f41a1e2
commit 73fd95d
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/crates/guest/src/init.rs b/crates/guest/src/init.rs
@@ -420,7 +420,12 @@ impl GuestInit {
         }
         env.extend(launch.env.clone());
         env.insert("KRATA_CONTAINER".to_string(), "1".to_string());
-        env.insert("TERM".to_string(), "vt100".to_string());
+
+        // If we were not provided a terminal definition in our launch manifest, we
+        // default to xterm as most terminal emulators support the xterm control codes.
+        if !env.contains_key("TERM") {
+            env.insert("TERM".to_string(), "xterm".to_string());
+        }
 
         let path = GuestInit::resolve_executable(&env, path.into())?;
         let Some(file_name) = path.file_name() else {