Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/s3 minor fixes #22

Merged
merged 10 commits into from
Sep 24, 2024
Merged

Feature/s3 minor fixes #22

merged 10 commits into from
Sep 24, 2024

Conversation

sametd
Copy link
Member

@sametd sametd commented Sep 20, 2024

Minor changes for s3:

  • use_ssl is used external url
  • separation of secure and use_ssl in minio
  • removal of random_host

@sametd
Copy link
Member Author

sametd commented Sep 24, 2024

Updated with complete rewrite of s3_staging.py, it works with latest version of minio-py. Also added depreciation warning to s3_staging.py . Furthermore, this implementation supports seaweedfs too.

@jameshawkes jameshawkes changed the base branch from master to develop September 24, 2024 20:25
@jameshawkes jameshawkes merged commit 5a289fb into develop Sep 24, 2024
8 checks passed
@jameshawkes jameshawkes deleted the feature/s3-minor-fixes branch September 24, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants