Bugfix/pep fixes for qa #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameshawkes
reviewed
Aug 19, 2024
| import yaml | ||
|
|
||
| from ..caching import cache | ||
| from . import datasource | ||
|
|
||
| os.environ["GRIBJUMP_HOME"] = "/opt/fdb-gribjump" |
There was a problem hiding this comment.
I think this is here, along with the import polytope to pre-seed pygribjump module with the correct config. Would be best to revert this and add PEP ignores for now. I think there is a PR in gribjump to accept the config at construction which we could use instead (soon).
sametd
force-pushed
the
bugfix/pep-fixes-for-qa
branch
from
ccad961
to
d8328e4
Compare
sametd
force-pushed
the
bugfix/pep-fixes-for-qa
branch
from
d8328e4
to
f94d9ea
Compare
jameshawkes
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses various PEP-related issues that were causing code quality failures in GitHub Actions.