Refactor SphericalVector interpolation method to use array::ArrayViewVariant.
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odlomax
force-pushed
the
feature/refactor_spherical_vector
branch
2 times, most recently
from
a065858
to
5098968
Compare
wdeconinck
force-pushed
the
feature/refactor_spherical_vector
branch
from
5098968
to
aafdd84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last of this batch of PRs that refactors the
SphericalVectorinterpolation method. Here we've usedstd::visitonArrayViewVariantto resolve the rank and type of the arrays instead of several verboseifstatements and function overloads.This PR depends on PRs #220, #223, #224 and #226. It closes issue #217.