Sanitise: Update scope on unchanged expressions in remove_associates #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default case is the one, where the symbol is associates by the closest associate, but that associates is about to be removed. So we simply update the scope to ensure nothings becomes unscoped.
|
Documentation for this branch can be viewed at https://sites.ecmwf.int/docs/loki/439/index.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 212 212
Lines 40259 40281 +22
=======================================
+ Hits 37535 37558 +23
+ Misses 2724 2723 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default case is the one, where the symbol is associates by the closest associate, but that associates is about to be removed. So we simply update the scope to ensure nothing becomes unscoped.
Note, I believe this should fix issue #438 . The PR includes a much simplified test case.