Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/e2e irs preparation #109

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

ds-jhartmann
Copy link
Contributor

@ds-jhartmann ds-jhartmann commented Jul 19, 2024

Description

This PR includes the following:

  • values-adopter-irs.yaml, which contains the required configuration for the IRS to be able to consume data. The values can be used in a GH workflow for E2E tests.
  • EDC discovery mock, which can be configured to map any BPN to a certain EDC

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@ds-jhartmann ds-jhartmann marked this pull request as ready for review July 29, 2024 09:24
Base automatically changed from chore/edc-0.7.0-iam-mock to upgrade/24.05 July 30, 2024 11:44
@tunacicek
Copy link
Contributor

Hi @ds-jhartmann :
Only for my understanding:
Is there an reason to not use the wiremock helm chart instead of building our own helm and use the wiremock image.
https://github.com/wiremock/helm-charts/tree/master/charts/wiremock

@tunacicek tunacicek self-requested a review August 5, 2024 11:43
Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@ds-jhartmann
Copy link
Contributor Author

Hi @ds-jhartmann : Only for my understanding: Is there an reason to not use the wiremock helm chart instead of building our own helm and use the wiremock image. https://github.com/wiremock/helm-charts/tree/master/charts/wiremock

Hi @tunacicek thanks for the review.
When I first created the EDC discovery mock for the IRS about a year go, I did not find any suitable wiremock helm charts, so I went and created my own (which is the one I use here as well).
It would probably be better to use the one you linked, but I could not find a comprehensible documentation on how to set-up the stubs, so I cannot quickly migrate to the wiremock helm chart.
For now I would prefer to keep the dedicated chart

Copy link
Contributor

@tunacicek tunacicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general!
Could you please update the information about installed components with the discovery-mock in the README.md and add a section about how to use in the adopters section of the README.md?
Also, should the discovery-mock maybe be added to the test file for decentral services https://github.com/eclipse-tractusx/tractus-x-umbrella/blob/chore/e2e-irs-preparation/charts/values-test-data-exchange.yaml?

@evegufy
Copy link
Contributor

evegufy commented Aug 14, 2024

I'm changing the base branch to main as the update to R24.05 has been merged to main

@evegufy evegufy changed the base branch from upgrade/24.05 to main August 14, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants