Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Business Partner KIT] Release 24.08 #988

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

SujitMBRDI
Copy link
Contributor

Description

In this pull request, we have updated changes in business partner kit related to release 24.08.

  • updated api endpoint details for bpdm services like gate, pool and orchestrator
  • removed documentation related to bpdm bridge dummy service

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@jSchuetz88
Copy link
Member

jSchuetz88 commented Jul 17, 2024

Thank you for your contribution.
As the change comprises more than 1000 lines, has an IP check already been triggered?
(TRG 7.03: https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-03/)

*Note: There is a chance, that the IP check won't be required. The openAPI plugin will be discontinued and the API and the respective MDX-files needs to be removed, please see the following guidance: #970

After the removal of the APIs maybe you won't have more than 1000 lines anymore.

@SujitMBRDI

@SujitMBRDI
Copy link
Contributor Author

Thank you for your contribution. As the change comprises more than 1000 lines, has an IP check already been triggered? (TRG 7.03: https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-03/)

*Note: There is a chance, that the IP check won't be required. The openAPI plugin will be discontinued and the API and the respective MDX-files needs to be removed, please see the following guidance: #970

After the removal of the APIs maybe you won't have more than 1000 lines anymore.

@SujitMBRDI

@jSchuetz88,
Thanks for reviewing pull request.
Being committer, I think i can make the changes without creating IP check which I am quite use to do for this repo during multiple releases in past.
(Ref TRG 7.03: https://eclipse-tractusx.github.io/docs/release/trg-7/trg-7-03/#contributions-by-a-tractus-x-committer)

Yeah, you rightly said after successful migration to API hub, we won't have more that 1000 lines anymore.
In past, I already tried SwaggerHub movement and their limitations are also well known for me.
But are we planning to finish #970 in 24.08?

maximilianong
maximilianong previously approved these changes Jul 17, 2024
@jSchuetz88
Copy link
Member

jSchuetz88 commented Jul 17, 2024

@SujitMBRDI

Being committer, I think i can make the changes without creating IP check which I am quite use to do for this repo during multiple releases in past.

My bad, you are right.

But are we planning to finish #970 in 24.08?

Yes, the removal is mandatory as we prepare to update docusaurus, which is currently blocked by the API plugin. As this PR is technically already compliant to TRG 1.08, only the MDX-files have to be removed.


@danielmiehle After the removal of the MDX-files, this PR is good to go from my side.

Copy link

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes made here are all good.

However, since this pull request should reflect all updates for 24.08 I propose additional changes in the Operators View to remove outdated or confusing information. I created an issue for that here #990

Question is just if we want to address these issues in this pull request or create a new one @SujitMBRDI

@SujitMBRDI
Copy link
Contributor Author

SujitMBRDI commented Jul 18, 2024

Question is just if we want to address these issues in this pull request or create a new one @SujitMBRDI

We can adapt operation view in same pull request.

@SujitMBRDI
Copy link
Contributor Author

Question is just if we want to address these issues in this pull request or create a new one @SujitMBRDI

We can adapt operation view in same pull request.

@nicoprow I have adapted changes for operation view mentioned in #990. Now, recent commit streamlines both BPDM repository information and information on present Business Partner KITs.

Copy link

@nicoprow nicoprow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the Operation View had still some good parts we can overtake. But the content looks good now and is up-to-date

@SujitMBRDI SujitMBRDI merged commit 8d226be into eclipse-tractusx:main Jul 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants