Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circularity kit update 24.08 adoption view fixed #1088

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LuisRickert
Copy link
Contributor

@LuisRickert LuisRickert commented Nov 14, 2024

Description

Added

  • add new figures
  • add license files for new figures

Changed

  • change strucutre of the contents. Same content chapters are in different order
  • change wording

Issue 703
REPLACES PR 925

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

Copy link
Member

@stephanbcbauer stephanbcbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuisRickert thanks for the PR. Can you please check the DEPENDENCIES file? It seems to be outdated. Since this is a PR with more than 1000 changes, I have to create an IP Ticket on the Eclipse side.
⇾ I will do this and link it to the PR.

Furthermore, thanks for adding the licence files for each picture … right now, there are many companies named. Is it just a copy & paste error? Or did they all contribute here? Or was this done by you?

@jSchuetz88 FYI

@LuisRickert
Copy link
Contributor Author

@LuisRickert thanks for the PR. Can you please check the DEPENDENCIES file? It seems to be outdated. Since this is a PR with more than 1000 changes, I have to create an IP Ticket on the Eclipse side. ⇾ I will do this and link it to the PR.

Furthermore, thanks for adding the licence files for each picture … right now, there are many companies named. Is it just a copy & paste error? Or did they all contribute here? Or was this done by you?

@jSchuetz88 FYI

I'll check the dependency file. Still i'm confused that this check is failing since i did a rebase for this fixed PR so it is up to date (Yesterday evening) and we didn't do any changes to that file.

wrt. the license files, i just used the exsisting one, since i was. just the person who was tasked to create the PR.

@LuisRickert
Copy link
Contributor Author

Hey @stephanbcbauer i did some investigation.

The "DEPENDENCIES" file is generated by the "3rd Party dependency"-Job based on the package-lock.json file. My reasoning:

  • if the file in my PR is identical to the file the main branch, which it is, the result of the check should be the same
  • this means the result of the check should be the same, ergo if it fails on my PR the check should also fail on the mail branch
  • i did the check locally on my PR and it failed as expected
  • the check also failed on the Main branch
  • but if i run the check via the github actions on my fork the check fails for PR branch but not for the main branch
    -> this result confuses me

are the any guidance on this or have i missed something ?
dash-license tool is 1.1.1-Snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants