-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(open meetings): delete downloadable calendar files #1078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it appears that you remove much more ics file than meetingLinks
yes you are right -> cleanup, cause for trace-x we had two ics files, but the related open meetings were already deleted some time ago. |
ah ok. forgot the committer meeting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be consequent, there is the extended EDC meeting, where the calender file should be gone as well. And I would propose to also do this for the one time meetings. But I would agree to not change them, as the planning is just on Wednesday. We could remove them afterwards and change procedure for next time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved with understanding that a change to improve consistency will follow after tomorrow's planning
Correct -> after tomorrow ... there will be a new PR deleting all the other calendar files. |
Description
This PR deletes the unused ics files (as in the office hour discussed):
and it also deletes the broken files (daylight/summer/wintertime)
it also deletes the reference to these files in the open meetings.
Please also help to discuss the schedules (e.g. schedule="Every Tuesday from 10:30 am to 11:00 am CEST") what would here the best? Since CEST doesn't fit any more.
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: