Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(open meetings): delete downloadable calendar files #1078

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

stephanbcbauer
Copy link
Member

@stephanbcbauer stephanbcbauer commented Nov 8, 2024

Description

This PR deletes the unused ics files (as in the office hour discussed):

  • security-office-hour.ics
  • coordination-feature-development-trace-x.ics
  • alignment-and-planning-trace-x.ics

and it also deletes the broken files (daylight/summer/wintertime)

  • committer-office-hour.ics
  • office-hour.ics
  • portal-open-meeting.ics

it also deletes the reference to these files in the open meetings.

  • Only for the EDC weekly, i didn't delete it cause somehow it works here @lgblaumeiser -> please confirm
  • also for the one-time meetings the files are not deleted, cause these files were created during coreect daylight/wintertime/summertime

Please also help to discuss the schedules (e.g. schedule="Every Tuesday from 10:30 am to 11:00 am CEST") what would here the best? Since CEST doesn't fit any more.

Pre-review checks

Please ensure to do as many of the following checks as possible, before asking for committer review:

@stephanbcbauer stephanbcbauer self-assigned this Nov 8, 2024
@stephanbcbauer stephanbcbauer added the documentation Improvements or additions to documentation label Nov 8, 2024
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it appears that you remove much more ics file than meetingLinks

@evegufy evegufy changed the title docs(open meetimgs): delete downloadable calendar files docs(open meetings): delete downloadable calendar files Nov 8, 2024
@stephanbcbauer
Copy link
Member Author

it appears that you remove much more ics file than meetingLinks

yes you are right -> cleanup, cause for trace-x we had two ics files, but the related open meetings were already deleted some time ago.

@stephanbcbauer
Copy link
Member Author

it appears that you remove much more ics file than meetingLinks

yes you are right -> cleanup, cause for trace-x we had two ics files, but the related open meetings were already deleted some time ago.

ah ok. forgot the committer meeting

Copy link
Contributor

@lgblaumeiser lgblaumeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be consequent, there is the extended EDC meeting, where the calender file should be gone as well. And I would propose to also do this for the one time meetings. But I would agree to not change them, as the planning is just on Wednesday. We could remove them afterwards and change procedure for next time.

Copy link
Contributor

@lgblaumeiser lgblaumeiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ClosedSourcerer ClosedSourcerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 7 ICS files are to be removed
  • 4 meetingLink= referencing ICS files are to be removed
  • 4 meetingLink= and ICS files do remain
  • The ICS files for Refinement Day 1 has an teams invite link set as location
    image

The proposed changes LGTM, but imho all ICS files and references should be removed for consistency

@stephanbcbauer stephanbcbauer requested a review from a team November 12, 2024 10:30
Copy link
Contributor

@evegufy evegufy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with understanding that a change to improve consistency will follow after tomorrow's planning

@stephanbcbauer
Copy link
Member Author

approved with understanding that a change to improve consistency will follow after tomorrow's planning

Correct -> after tomorrow ... there will be a new PR deleting all the other calendar files.

@stephanbcbauer stephanbcbauer merged commit fd859a8 into main Nov 13, 2024
5 checks passed
@stephanbcbauer stephanbcbauer deleted the docs/delete-calendar-files branch November 13, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants