Mark unused methods for removal in WorkbenchWindowAdvisor #2501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 821 files ±0 1 821 suites ±0 1h 51m 59s ⏱️ - 3m 30s For more details on these failures, see this check. Results for commit 560c490. ± Comparison against base commit beb9918. ♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
workbench-window-advisor-mark-methods-for-deletion
branch
from
f5f77ed
to
00f34d6
Compare
|
Awesome this new quality gate check! This prevented me from adding more warnings to the build. I assume I have to thank you @laeubi for this. Great work! |
vogella
force-pushed
the
workbench-window-advisor-mark-methods-for-deletion
branch
from
00f34d6
to
d235146
Compare
These methods are not used since the 3.x migration, time to mark them for deletion.
vogella
force-pushed
the
workbench-window-advisor-mark-methods-for-deletion
branch
from
d235146
to
560c490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These methods are not used since the 3.x migration, time to mark them for deletion.