Avoid "null" in "Show In" menu when there is no key binding #2472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 1 821 files ±0 1 821 suites ±0 1h 48m 12s ⏱️ - 6m 13s For more details on these failures, see this check. Results for commit 000f4db. ± Comparison against base commit 83c128c. ♻️ This comment has been updated with latest results. |
Wittmaxi
reviewed
Nov 4, 2024
| @@ -45,6 +45,6 @@ private String getShowInMenuLabel() { | |||
| ? bindingService | |||
| .getBestActiveBindingFormattedFor(IWorkbenchCommandConstants.NAVIGATE_SHOW_IN_QUICK_MENU) | |||
| : ""; //$NON-NLS-1$ | |||
| return WorkbenchNavigatorMessages.ShowInActionProvider_showInAction_label + '\t' + keyBinding; | |||
| return WorkbenchNavigatorMessages.ShowInActionProvider_showInAction_label + (keyBinding != null ? "\t" + keyBinding : ""); //$NON-NLS-1$ //$NON-NLS-2$ | |||
There was a problem hiding this comment.
From a static analysis, this looks sound. I looked into other ActionProviders and couldn't see in a glance why they don't have the same problem and how they solve that problem. Is there any mechanism we might have missed here?
| } |
There was a problem hiding this comment.
please keep the diff clean!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the "Show In" command has no key binding (we disable it for our reasons in our product), there is a
nulllabel in the menu:The proposed change fixes this issue.