Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change path name -bundle 6 #2437

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elsazac
Copy link
Member

@elsazac elsazac commented Oct 21, 2024

Refs: #1460

Changing the path name from "Eclipse UI" to "eclipseui" to avoid space in path names and to make it UNIX friendly.

For : /bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/splash/ bundles

File paths changed are :

1. bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/splash/BasicSplashHandler.java
2. bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/splash/package.html
3. bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/splash/AbstractSplashHandler.java

…e in path names and to make it UNIX friendly. For bundles : /bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/splash/
Copy link
Contributor

Test Results

0 files   -  1 818  0 suites   - 1 818   0s ⏱️ - 1h 50m 32s
0 tests  -  7 711  0 ✅  -  7 482  0 💤  - 228  0 ❌  - 1 
0 runs   - 24 294  0 ✅  - 23 546  0 💤  - 747  0 ❌  - 1 

Results for commit 2c3b803. ± Comparison against base commit 9f38380.

@akurtakov
Copy link
Member

I see you continue doing more and more such drafts but not finishing the first one and push it, why?

@elsazac
Copy link
Member Author

elsazac commented Oct 22, 2024

I see you continue doing more and more such drafts but not finishing the first one and push it, why?

@akurtakov Following your advice here , I am preparing all the PR's in advance to land all at once. Isn't it what you meant?

@akurtakov
Copy link
Member

This comment was continuation of #2411 (comment) aka "all PRs" in the comment you pointed to means "all PRs in different git repositories for single bundle source folder renames"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants