Change the classes with shortcut #2413
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannisCode
force-pushed
the
tab_change
branch
4 times, most recently
from
21d07b3
to
402bd75
Compare
Test Results 1 821 files ±0 1 821 suites ±0 1h 52m 18s ⏱️ + 6m 53s For more details on these failures, see this check. Results for commit 473cefe. ± Comparison against base commit 136afb4. ♻️ This comment has been updated with latest results. |
Wittmaxi
requested changes
Oct 17, 2024
| * | ||
| * @param folder | ||
| * @return if there are any items which are not shown in the folder (tabs in the | ||
| * >> column) |
There was a problem hiding this comment.
the ">> column" is called "the chevron"
There was a problem hiding this comment.
| /** | ||
| * checks if there are any hidden items | ||
| * | ||
| * @param folder |
| * >> column) | ||
| */ | ||
| private boolean areHiddenItems(CTabFolder folder) { | ||
| for (CTabItem i : folder.getItems()) { |
There was a problem hiding this comment.
| /** | ||
| * Sets the current selection to the second-to-last item in the given direction. | ||
| * | ||
| * @param folder |
There was a problem hiding this comment.
describe folder and forward
jannisCode
force-pushed
the
tab_change
branch
10 times, most recently
from
e40fc60
to
bb64c62
Compare
jannisCode
added a commit
to jannisCode/eclipse.platform.ui
that referenced
this pull request
Oct 23, 2024
Tab change can now handle the chevron. And after reaching the last tab, it jumps to the first, if chevron doesn´t exist eclipse-platform#2413
jannisCode
force-pushed
the
tab_change
branch
from
bb64c62
to
66be584
Compare
jannisCode
added a commit
to jannisCode/eclipse.platform.ui
that referenced
this pull request
Oct 25, 2024
Tab change can now handle the chevron. And after reaching the last tab, it jumps to the first, if chevron doesn´t exist eclipse-platform#2413
jannisCode
force-pushed
the
tab_change
branch
from
66be584
to
9a98ff4
Compare
jannisCode
added a commit
to jannisCode/eclipse.platform.ui
that referenced
this pull request
Oct 25, 2024
Tab change can now handle the chevron. And after reaching the last tab, it jumps to the first, if chevron doesn´t exist eclipse-platform#2413
jannisCode
force-pushed
the
tab_change
branch
from
9a98ff4
to
867d55e
Compare
jannisCode
added a commit
to jannisCode/eclipse.platform.ui
that referenced
this pull request
Oct 28, 2024
Tab change can now handle the chevron. And after reaching the last tab, it jumps to the first, if chevron doesn´t exist eclipse-platform#2413
jannisCode
force-pushed
the
tab_change
branch
from
867d55e
to
89130d3
Compare
jannisCode
added a commit
to jannisCode/eclipse.platform.ui
that referenced
this pull request
Nov 5, 2024
Tab change can now handle the chevron. And after reaching the last tab, it jumps to the first, if chevron doesn´t exist eclipse-platform#2413
jannisCode
force-pushed
the
tab_change
branch
from
89130d3
to
9553700
Compare
Tab change can now handle the chevron. And after reaching the last tab, it jumps to the first, if chevron doesn´t exist eclipse-platform#2413
jannisCode
force-pushed
the
tab_change
branch
from
9553700
to
473cefe
Compare
Wittmaxi
requested changes
Nov 14, 2024
| Control control = focusControl; | ||
|
|
| do { | ||
| if (control instanceof CTabFolder folder && isFinalItemInCTabFolder(folder, forward) | ||
| && !areHiddenItems(folder)) { | ||
| loopToSecondToFirstItemInCTabFolder(folder, forward); |
There was a problem hiding this comment.
"loopToSecondToFirstItemInCTabFolder" is not a desirable name. Are you referring to the "second to last" item or to the "second" item?
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
by convention, please add a line here
| return null; | ||
| } | ||
|
|
||
| private boolean areHiddenItems(CTabFolder folder) { | ||
| CTabItem[] items = folder.getItems(); | ||
| for (CTabItem i : items) { |
There was a problem hiding this comment.
| @@ -70,5 +124,4 @@ protected Method getMethodToExecute() { | |||
| } | |||
| return null; | |||
| } | |||
|
|
|||
| } | |||
| } | |||
There was a problem hiding this comment.
please keep the diff clean
| } | ||
| } | ||
|
|
||
| /**https://github.com/jannisCode/eclipse.jdt.ui.git |
There was a problem hiding this comment.
By convention, the first line of javadoc comments is empty (atleast that's what I have seen everywhere else)
| } | ||
|
|
||
| /** | ||
| * Sets the current selection to the second-to-last item in the given direction. |
There was a problem hiding this comment.
second to last? or second to first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR finishes the PR started by @Wittmaxi , who also did most of the work here: #1874
The objective of @Wittmaxi ´s PR is to be able to expand the functionality of the nextTab shortcut (default crtl + pgdown) so that after reaching the last tab, one more click changes the active tab back to the first one.
What this PR does
When there are too many tabs open, #1874 still went back to the first tab, ignoring the remaining tabs stored in the chevron (the >> container).
With the changes from this PR, when there are stored tabs in the chevron, clicking once more after the last tab has the same functionality as the default eclipse, going into the chevron.
tabaction.mp4