Remove package import of sun.security.x509 #23
Conversation
This package is only imported in a test [1] which isn't part of the Orbit bundle we create. The java.base module doesn't export this internal package [2] which can't be used anymore on Java 17 or higher due to the stronger encapsulation of Java internals introduced with JEP 403 [3]. [1] https://github.com/str4d/ed25519-java/blob/7c26a6312c2d2e887210930698706103e0f2da7d/test/net/i2p/crypto/eddsa/EdDSAEngineTest.java#L34 [2] https://github.com/openjdk/jdk17/blob/master/src/java.base/share/classes/module-info.java#L345 [3] https://openjdk.org/jeps/403
|
I asked Fred and he said "they can open a helpdesk issue. most likely this is the known issue for projects that are still on the eclipse GitHub org and sharing github action minutes with several other projects." I know Orbit is waiting the eclipse-orbit organization to be available... |
|
Why did we move away from Jiro to Github actions in a Github organization where we compete for limited action minutes with many other projects ? |
|
Actually a PR fixing this issue upstream was approved in 2019: It seems this project was abandoned in favour of JEP 339 added a ed25519 implementation to Java 15, see https://openjdk.org/jeps/339 |
Its not that we moved away - its just no one has invested in the Jiro for Orbit since we moved to GitHub (and the GHA was trivial to add) - contributions welcome :-) |
|
If someone nominates me as a committer, I can help with such things as a multi-branch pipeline... |
|
This package is only imported in a test [1] which isn't part of the Orbit bundle we create. The java.base module doesn't export this internal package [2] which can't be used anymore on Java 17 or higher due to the stronger encapsulation of Java internals introduced with JEP 403 [3].
[1] https://github.com/str4d/ed25519-java/blob/7c26a6312c2d2e887210930698706103e0f2da7d/test/net/i2p/crypto/eddsa/EdDSAEngineTest.java#L34
[2] https://github.com/openjdk/jdk17/blob/master/src/java.base/share/classes/module-info.java#L345
[3] https://openjdk.org/jeps/403