Migrate to JUnit 5 - Jenkins #51 #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruspl-afed
reviewed
Aug 7, 2024
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Tasktop Technologies - initial API and implementation | ||
| * See git histpry |
| @@ -11,6 +11,7 @@ | |||
| * Tasktop Technologies - improvements | |||
| * Eike Stepper - improvements for bug 323759 | |||
| * Benjamin Muskalla - 323920: [build] config retrival fails for jobs with whitespaces | |||
| * See git histpry | |||
| @@ -16,7 +16,11 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="0.0.0", | |||
| org.eclipse.search;bundle-version="0.0.0", | |||
| org.eclipse.ui;bundle-version="0.0.0", | |||
| org.eclipse.ui.workbench.texteditor;bundle-version="0.0.0", | |||
| org.junit;bundle-version="4.8.2" | |||
| junit-jupiter-api;bundle-version="5.10.3", | |||
There was a problem hiding this comment.
I would recommend to prefer "Import-Package" for 3rd party libs
There was a problem hiding this comment.
Sure.
I wasn't sure about that so I just followed what was done with JUnit 4
There was a problem hiding this comment.
So I tried "importing" and had to add the libraries to the .target file with older versions. So I don't know what is the best solution?
I'm still trying to figure out how all this works.
What are the pros and cons of using the versions made available implicitly vs the ones from the orbit/drop/??? sites
| @@ -8,6 +8,7 @@ | |||
| * SPDX-License-Identifier: EPL-2.0 | |||
| * | |||
| * Tasktop Technologies - initial API and implementation | |||
| * See git histpry | |||
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Tasktop Technologies - initial API and implementation | ||
| * See git histpry |
| @@ -10,14 +10,17 @@ | |||
| * Tasktop Technologies - initial API and implementation | |||
| * Guy Perron - add Windows support | |||
| * ArSysOp - ongoing support | |||
| * See git histpry | |||
| * SPDX-License-Identifier: EPL-2.0 | ||
| * | ||
| * Tasktop Technologies - initial API and implementation | ||
| * ArSysOp - ongoing support | ||
| * See git histpry |
BeckerFrank
reviewed
Aug 10, 2024
| import org.eclipse.mylyn.jenkins.tests.support.JenkinsFixture; | ||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| public class SuiteSetup { |
There was a problem hiding this comment.
I think we need instead a JUnit 5 Extensions or some other new feature so that we can support multible fixtures
ruspl-afed
force-pushed
the
51-migrate-to-junit-5
branch
from
1a4e301
to
ac49fb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of Concept replacing JUnit 4 with JUnit 5
Convert Jenkins unit tests
Conditionally re-enable the CI runs if a CI server can be reached. CI server setup using the multipass scrips created by @BeckerFrank
Task-Url: #51