simplify loop in collect_exts_file_info
#4689
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loop over
exts_list
uses an excessive amount of branches and hence indentation making it hard to read.We have 3 simple cases:
Moving the type check to the top of the loop makes it instantly visible which types are accepted, the
elif
s at the bottom are hard to find after all the indents.Using
continue
after handling the simple cases reduces the indentation by 2 levels and makes it clear, that nothing else is done for those.