Proposed changest to add a timeout
to run_shell_cmd
#4665
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes would implement the capability for
run_shell_cmd
to fail after a user-specifiedtimeout
.This would be useful for commands that are known to possibly hang to fail gracefully and report meaningful logs, instead of blocking EB indefinitely.
The PR leverages the already implemented timeout in Popen.communicate (since python 3.3) for non-interactive/streamed usage of
run_shell_cmd
In case of an interactive/streamed run the following has been added:
run.py
read_pipe
: read from a pipe using a thread and raise aTimeoutError
in case the read operation is taking longer than the specified timeoutterminate_process
: attempt to terminate a process gracefully by usingPopen.terminate
first andPopen.kill
after. Raises an EasybuildError if the process is still alive aftertimeout
run_shell_cmd
timeout
timetimeout
timeout