Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow extensions to add text to the module file #4652

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

allow extensions to add text to the module file #4652

wants to merge 5 commits into from

Commits on Sep 23, 2024

  1. Add Python 3.1 assertRegex to test class

    @Flamefire
    Flamefire committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    095e1e5 View commit details
    Browse the repository at this point in the history

  2. Ensure correct line breaks in module footer 

    The different options for the module footers did not have consistent
newline handling:
- modtclfooter & modluafooter did append a line break
- modules_footer (cmdline) did not

Make sure all end with a new line such that they work in combination
especially with the EasyBuild version comment moved to the bottom
    @Flamefire
    Flamefire committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    befc8bd View commit details
    Browse the repository at this point in the history

  3. allow extensions to add text to the module file 

    Introduce `make_extension_module_extra` which gets called during module
file creation for every extension similar to `make_module_extra`.
This ensures it will also be called for parallel extension or --module-only builds.

Fixes easybuilders#4647
    @Flamefire
    Flamefire committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    3e6d483 View commit details
    Browse the repository at this point in the history

  4. Init extensions before loading (fake) module 

    The extensions are required by the module creation and will be loaded if
they are not yet.
In `extensions_step` they would then be loaded again.
Avoid this by doing this earlier in `extensions_step`
    @Flamefire
    Flamefire committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    5fcfc18 View commit details
    Browse the repository at this point in the history

  5. Remove EasyBlock.exts_all 

    This is always equal to `self.exts` as skipping is done on
`self.ext_instances`.
    @Flamefire
    Flamefire committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    224f494 View commit details
    Browse the repository at this point in the history