-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use pdbufr to read DWD radar data in bufr format #482
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #482 +/- ##
=========================================
Coverage 90.85% 90.86%
=========================================
Files 103 85 -18
Lines 9856 5263 -4593
Branches 1133 443 -690
=========================================
- Hits 8955 4782 -4173
+ Misses 703 372 -331
+ Partials 198 109 -89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
b9a919c
to
b2c8bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @gutzbenj I hope you are fine.
I took a look to your first code for handling DWD bufr data. I hope this helps you.
If you want I can write some tests for it ;) Let me know.
"latitude", | ||
"longitude", | ||
"horizontalReflectivity", | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think more meta data is required to work with radar data.
- Number of radial bins
- range
- azimuth
Take a look at step 11 at https://docs.wradlib.org/en/stable/notebooks/fileio/wradlib_load_DWD_opendata_volumes.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint! This was just a first guess as with pdbufr you will have to set everything you want to read in beforehand and can't just read everything that's being found in the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @meteoDaniel , could you please check the latest state of the PR? I also couldn't figure out if the information of
- Number of radial bins
- range
- azimuth
is contained within the bufr files.
2487b88
to
c9900cb
Compare
07934b8
to
a9ce842
Compare
cef9020
to
783eeab
Compare
f98a8b6
to
722c9d5
Compare
c6deea1
to
5023bab
Compare
b9dadd9
to
f4d1daf
Compare
As suggested by @meteoDaniel this adds pdbufr to the requirements and allows to parse the provided bufr radar data by DWD to a pandas DataFrame. (testing not possible atm as data is not available)
Fixes #364
UPDATE
This won't currently work as of the loose connection between eccodes (the core library) and its python bindings. Differences between versions can lead to an ImportError which is caused by the core library not being found. We should wait for this to be solved to be able to run ordinary checks on bufr files.
UPDATE2
Provision errors of eccodes library can now individually be solved by setting such environmental variable