-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/brokerless p2p #164
base: foxy
Are you sure you want to change the base?
Conversation
uxrObjectId * object_id = &brokerlessEntityMap.queue[hash_index].id; | ||
|
||
// TODO (pablogs9): request_id is related to the uxr_buffer_request_data request, so it can determine some limitations imposed into the communication -> NOT IMPLEMENTED BY NOW | ||
if (object_id->type == UXR_DATAREADER_ID) | ||
{ | ||
uxrStreamId stream = {0, 0, UXR_BROKERLESS, UXR_INPUT_STREAM}; | ||
uxrStreamId stream = {0, 0, UXR_BROKERLESS_STREAM, UXR_INPUT_STREAM}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check this, have you changed the stream type enum also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I just did it to maintain the coherence with the naming of the rest of the elements in the enum 🙂
@@ -72,7 +72,7 @@ int main(int args, char** argv) | |||
|
|||
char* ip = argv[1]; | |||
char* port = argv[2]; | |||
uint32_t key = (args == 4) ? (uint32_t)atoi(argv[3]) : 0xCCCCDDDD; | |||
uint32_t key = 0xCCCCDDDD; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be changed. Remember: keep unchanged.
|
||
#define STREAM_HISTORY 8 | ||
#define BUFFER_SIZE UXR_CONFIG_UDP_TRANSPORT_MTU * STREAM_HISTORY | ||
|
||
bool sended = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be changed. Remember: keep unchanged.
@@ -23,6 +23,7 @@ | |||
#define STREAM_HISTORY 8 | |||
#define BUFFER_SIZE UXR_CONFIG_UDP_TRANSPORT_MTU * STREAM_HISTORY | |||
|
|||
uint32_t last_index = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should not be changed. Remember: keep unchanged.
UXR_RELIABLE_STREAM | ||
UXR_RELIABLE_STREAM, | ||
/** Identifies a brokerless stream. */ | ||
UXR_BROKERLESS_STREAM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the stream name, in the other file UXR_BROKERLESS_STREAM
is not being used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything is ok. My fault.
eb5aae4
to
223d69b
Compare
I think this is pretty cool - will it be worked on again? |
TODO: