Refactor code to a plugin design. Structural changes, functional modi… #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fications only to support new structure.
…ault by the urlshortner build, in the proper location. The existing projectreference(referenceoutputassumbly is false) ensures that plugin builds prior to the urlshortner proj, without copying its assembling to the wrong place.
bprussell
approved these changes
Oct 29, 2022
There was a problem hiding this comment.
I like the way you did this, and it makes total sense. I also pulled it down and tested the various calls and it all worked as it did before.
I'm not sure why the build is breaking, as I don't have access to the logs. @rorpage will need to look into that I think.
My only other comment would be to maybe clean up some of the commented out code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…fications only to support new structure.