Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added blank cargo package #45

Merged
merged 5 commits into from
Jan 1, 2024
Merged

added blank cargo package #45

merged 5 commits into from
Jan 1, 2024

Conversation

ZibanPirate
Copy link
Member

@ZibanPirate ZibanPirate commented Jan 1, 2024 •
edited
Loading

Description

  • First PR to add Rust support, followup PRs will come to write the actual kuliya implementation.
  • also updated the labeler CI check to v5 with breaking changes.

Implements #44
See also #11

Please ignore the labeler CI check.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Updated the dataset

@ZibanPirate ZibanPirate linked an issue Jan 1, 2024 that may be closed by this pull request
Add Rust support #44
Closed
@ZibanPirate ZibanPirate force-pushed the 44-add-rust-support branch 4 times, most recently from 4843b38 to a151ddb Compare January 1, 2024 17:03
@github-actions github-actions bot added the rust label Jan 1, 2024
@ZibanPirate ZibanPirate self-assigned this Jan 1, 2024
@ZibanPirate ZibanPirate marked this pull request as draft January 1, 2024 17:24
@ZibanPirate ZibanPirate changed the title adding rust support added blank cargo package Jan 1, 2024
@ZibanPirate ZibanPirate requested a review from a team January 1, 2024 17:28
@ZibanPirate ZibanPirate marked this pull request as ready for review January 1, 2024 17:30
omdxp
omdxp approved these changes Jan 1, 2024
View reviewed changes
Copy link
Member

@omdxp omdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a vulnerability check for the used crates as well?

@ZibanPirate
Copy link
Member Author

Should we add a vulnerability check for the used crates as well?

good point, will add that once we require other crates, for now it's empty cargo lock lib : )

@ZibanPirate ZibanPirate merged commit eb6bd07 into main Jan 1, 2024
4 of 5 checks passed
@ZibanPirate ZibanPirate deleted the 44-add-rust-support branch January 1, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omdxp omdxp omdxp approved these changes

Assignees

@ZibanPirate ZibanPirate

Labels
rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Rust support
2 participants
@ZibanPirate @omdxp