[WIP][dcli] Init again #117 #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 52.60% 49.30% -3.31%
==========================================
Files 64 68 +4
Lines 2456 2572 +116
==========================================
- Hits 1292 1268 -24
- Misses 1043 1190 +147
+ Partials 121 114 -7
Continue to review full report at Codecov.
|
- The downside of it is introducing x/tools/imports and drags in many more dependencies including goldenmark, is used by present (generating slide from markdown)
- `make install2` will install gommon2 and inject build info using ldflags
- call `imports.Process` in linter.CheckAndFormatImport
e.g. bh user register
tconfig is a traceable config package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#117