Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change DiagnosticableMixin to Diagnosticable #107

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

quanghd96
Copy link

DiagnosticableMixin is removed on flutter repository (master branch). Now, Diagnosticable is a mixin on stable. So we need change DiagnosticableMixin to Diagnosticable to fix "Error: Type 'DiagnosticableMixin' not found".

image

@quanghd96
Copy link
Author

@dylanwuzh is that ok?

@coleary01
Copy link

When will this likely be approved? It impacts on using "master" branch of Flutter.

@ymback
Copy link

ymback commented Jul 27, 2020

Also Beta

@peterlpt
Copy link

peterlpt commented Aug 1, 2020

现在在beta分支也有这个问题了,望 @dylanwuzh 早日合并此请求

@chandrabezzo
Copy link

@dylanwuzh In latest version of flutter, we need this change.

@guohuanle
Copy link

Now the version after 1.20 is not available. The temporary solution is to modify the source code and change "DiagnosticableMixin" to "DiagnosticableTreeMixin" so that both the new version and the old version are available. I don’t know if this modification is correct, I hope to update the version as soon as possible (some people say it can be changed to "Diagnosticable", but this only solves the problem of the new version of the SDK, the old version of the SDK is not compatible)

@quanghd96
Copy link
Author

@guohuanle if release new version, someone use old SDK can use old version of this library.

@LugonjaAleksandar
Copy link

LugonjaAleksandar commented Aug 10, 2020

Latest Flutter 1.20.1 now also has this issue, and plugin is unusable. Someone has to take care of this and merge it, otherwise no app can compile with latest Flutter version. @dylanwuzh can you please review this change since you are the biggest contributor to this repo, or at least tag someone who would be able to merge it....?

@TetsuFe
Copy link

TetsuFe commented Aug 10, 2020

I made another PR #124 to follow #107 (comment)
use DiagnosticableTreeMixin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants