Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Lists #165

Merged
merged 59 commits into from
Nov 1, 2023
Merged

PR: Lists #165

merged 59 commits into from
Nov 1, 2023

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Oct 5, 2022 •
edited by nelsonic
Loading

@SimonLab SimonLab added the in-progress An issue or pull request that is being worked on by the assigned person label Oct 5, 2022
@SimonLab SimonLab self-assigned this Oct 5, 2022
@SimonLab SimonLab temporarily deployed to dwylauth October 5, 2022 20:08 Inactive
@codecov
Copy link

codecov bot commented Oct 5, 2022 •
edited
Loading

Codecov Report

Merging #165 (6aae78a) into main (a0e1594) will decrease coverage by 0.31%.
Report is 60 commits behind head on main.
The diff coverage is 97.33%.

@@             Coverage Diff             @@
##              main     #165      +/-   ##
===========================================
- Coverage   100.00%   99.69%   -0.31%     
===========================================
  Files           22       26       +4     
  Lines          599      659      +60     
===========================================
+ Hits           599      657      +58     
- Misses           0        2       +2
Files Coverage Δ
lib/app/item.ex 100.00% <100.00%> (ø)
lib/app/list.ex 100.00% <100.00%> (ø)
lib/app_web/controllers/list_controller.ex 100.00% <100.00%> (ø)
lib/app_web/controllers/tag_controller.ex 100.00% <100.00%> (ø)
lib/app_web/live/components/nav.ex 100.00% <100.00%> (ø)
lib/app_web/live/stats_live.ex 100.00% <ø> (ø)
lib/app_web/router.ex 100.00% <ø> (ø)
lib/app_web/views/list_view.ex 100.00% <100.00%> (ø)
lib/app_web/views/nav_view.ex 100.00% <100.00%> (ø)
lib/app_web/live/app_live.ex 98.75% <91.30%> (-1.25%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SimonLab SimonLab temporarily deployed to dwylauth October 5, 2022 21:17 Inactive
@SimonLab
Create lists table and list schema
498a231 
Create the lists table
@SimonLab
Add list controller
13e3c6b 
Create list controller to add and edit lists
@SimonLab
Add item endpoint
3c3e83c 
Create item controller to link items to lists
@SimonLab SimonLab temporarily deployed to dwylauth October 5, 2022 21:39 Inactive
@SimonLab
Display lists under tags
ffe8d64 
- Add/Remove list linked to an item
- Display lists as badges on main page
@SimonLab SimonLab temporarily deployed to dwylauth October 7, 2022 10:55 Inactive
nelsonic
nelsonic reviewed Oct 7, 2022
View reviewed changes
lib/app/item.ex Outdated Show resolved Hide resolved
@SimonLab
Insert or get person
74e73ab 
Check if person exist before insert
@SimonLab SimonLab temporarily deployed to dwylauth October 7, 2022 19:56 Inactive
@SimonLab
Add tests for lists
a3269b7 
Add schemas and controllers tests
@SimonLab SimonLab temporarily deployed to dwylauth October 7, 2022 21:44 Inactive
@SimonLab SimonLab temporarily deployed to dwylauth October 8, 2022 14:33 Inactive
@SimonLab
Copy link
Member Author

SimonLab commented Oct 8, 2022

Displaying the item's lists under the tags:
image

@SimonLab SimonLab marked this pull request as ready for review October 8, 2022 14:40
@SimonLab
Add item controller test for lists
68f5562 
- Add test for item controller managing lists
- Fix #168
@SimonLab SimonLab temporarily deployed to dwylauth October 8, 2022 14:45 Inactive
@SimonLab SimonLab mentioned this pull request Oct 8, 2022
Closed
1 task
@SimonLab SimonLab assigned nelsonic and unassigned SimonLab Oct 8, 2022
@SimonLab SimonLab added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Oct 8, 2022
@nelsonic
Copy link
Member

image image

the "all" list is not editable as discussed in: #400 (comment)

This was referenced Sep 15, 2023
Closed
Closed
Merged
@nelsonic nelsonic mentioned this pull request Sep 16, 2023
Closed
3 tasks
@nelsonic nelsonic mentioned this pull request Nov 1, 2023
Closed
1 task
@nelsonic
Copy link
Member

nelsonic commented Nov 1, 2023

Custom Lists: :shipit:

custom-lists-showcase

@nelsonic nelsonic added the awaiting-review An issue or pull request that needs to be reviewed label Nov 1, 2023
nelsonic
nelsonic approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 😍 Thanks @SimonLab 👌

@nelsonic nelsonic merged commit 07c41ce into main Nov 1, 2023
1 check passed
@nelsonic nelsonic deleted the items-list branch November 1, 2023 17:32
@LuchoTurtle LuchoTurtle mentioned this pull request Nov 1, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review An issue or pull request that needs to be reviewed in-progress An issue or pull request that is being worked on by the assigned person
Projects
Nelson's List
Status: Done
dwyl app kanban
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimonLab @nelsonic @LuchoTurtle