Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted to Go Modules from using Dep #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikeschinkel
Copy link

Hi — I converted your project to using Go Modules instead of Dep.

I did not remove Dep's Gopkg.* files or the /vendor directory so that it would be easier to review the PR, but ideally you probably want to remove them using these commands from the repo root if Mac/Linux:

rm Gopkg.*
rm -rf vendor/

If Windows, I am sure you can figure it out.

I also added a build-run.sh command that should run on Mac/Linux to show how it needed to be compiled with modules, and to generate an output executable as bin/sa-bot. The -mod=mod switch won't be required once you remove/delete the above mentioned /vendor directory.

I hope this is useful and that you can accept this pull request.

Also, would be great if you could follow up and add that promised LICENSE file to your repo. Thanks in advance.

@mikeschinkel mikeschinkel changed the title Converted from using Dep to Go Modules Converted to Go Modules from using Dep Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant