Enable phishing protection for internal users #2483
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated file outputs:Time updated: Fri, 15 Nov 2024 14:41:50 GMT legacytrackers-unprotected-temporary.txt (13 more)
v3/ios-config.json--- v3/ios-config.json
+++ v3/ios-config.json
@@ -6208,9 +6208,9 @@
}
]
},
"phishingDetection": {
- "state": "disabled",
+ "state": "internal",
"exceptions": [
{
"domain": "marvel.com",
"reason": "https://github.com/duckduckgo/privacy-configuration/issues/1194"
@@ -6230,9 +6230,17 @@
{
"domain": "instructure.com",
"reason": "https://github.com/duckduckgo/privacy-configuration/issues/2212"
}
- ]
+ ],
+ "features": {
+ "allowErrorPage": {
+ "state": "internal"
+ },
+ "allowPreferencesToggle": {
+ "state": "internal"
+ }
+ }
},
"pluginPointFocusedViewPlugin": {
"state": "disabled",
"exceptions": []
latestv4/android-config.json (12 more)
v4/ios-config.json--- v4/ios-config.json
+++ v4/ios-config.json
@@ -5705,9 +5705,9 @@
}
]
},
"phishingDetection": {
- "state": "disabled",
+ "state": "internal",
"exceptions": [
{
"domain": "marvel.com"
},
@@ -5722,9 +5722,17 @@
},
{
"domain": "instructure.com"
}
- ]
+ ],
+ "features": {
+ "allowErrorPage": {
+ "state": "internal"
+ },
+ "allowPreferencesToggle": {
+ "state": "internal"
+ }
+ }
},
"pluginPointFocusedViewPlugin": {
"state": "disabled",
"exceptions": []
|
Thanks for the speedy review @quanganhdo ! |
jonathanKingston
removed this pull request from the merge queue due to a manual request
|
This should have a features/ file describing the feature. (I'll add linting to prevent this happening in future) |
jonathanKingston
requested changes
Nov 15, 2024
|
I created: #2484 to ensure this doesn't happen in future :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
Description
Enable Phishing Detection feature flag for internal users [iOS]
Reference