Add AsanaUploadAction #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
reviewed
Sep 2, 2024
Comment on lines
20
to
27
| url = Helper::DdgAppleAutomationHelper::ASANA_API_URL + "/tasks/#{task_id}/attachments" | ||
| response = HTTParty.post(url, | ||
| headers: { 'Authorization' => "Bearer #{token}" }, | ||
| body: { file: file }) | ||
|
|
||
| unless response.success? | ||
| UI.user_error!("Failed to upload file to Asana task: (#{response.code} #{response.message})") | ||
| end |
There was a problem hiding this comment.
Since UI.user_error! doesn't cause a test to stop (while it causes fastlane to stop the action/lane), it's tricky to test UI.user_error! stopping execution. I would suggest that we include all this code under begin/rescue clause, so that UI.user_error! calls are always the last thing to happen within #run function.
This may not scale as the complexity of our action raises and we may need to either find a different solution or stop testing user_error that thoroughly :/
| unless response.success? | ||
| UI.user_error!("Failed to upload file to Asana task: (#{response.code} #{response.message})") | ||
| end | ||
| rescue Errno::ENOENT |
There was a problem hiding this comment.
I think at least Errno::EPERM could also be raised here for file that the user has no permission to access, so perhaps we could just use rescue here:
Suggested change
| rescue Errno::ENOENT | |
| rescue |
ayoy
approved these changes
Sep 2, 2024
spec/asana_upload_action_spec.rb
Outdated
| end | ||
|
|
||
| it "shows error if file does not exist" do | ||
| allow(HTTParty).to receive(:post).and_return(double(success?: true)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task URL: https://app.asana.com/0/1201392122292466/1208137627434497/f
Description:
This change adds new lane that replaces asana-upload action