Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit testing #12

Open
wants to merge 6 commits into
base: dominik/start-new-release
Choose a base branch
from
Open

Unit testing #12

wants to merge 6 commits into from

Conversation

kshann
Copy link
Contributor

@kshann kshann commented Nov 11, 2024

Task/Issue URL: https://app.asana.com/0/72649045549333/1208137627434479/f

Description:
Adds unit tests for the following

  • start_new_release action
  • bump_build_number action
  • update_asana_for_release action
  • validate_internal_release_bump action

Also adds unit tests coverage for sub functionality in

  • ddg_apple_automation_helper.rb
  • asana_helper.rb

Minor bugfix for task processing,

  • Fixed breaking out of loop early when completing multiple tasks

@kshann kshann requested a review from ayoy November 11, 2024 09:52
@kshann
Copy link
Contributor Author

kshann commented Nov 11, 2024

@ayoy Opted to raise this against your branch to make it easier to review changes. Hopefully we can review here, then version bump your branch and merge to main when we're happy. Coverage is unintentionally at 95.74%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant