Add CMPs #492
Open
Add CMPs #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seia-soto
changed the title
muodov
reviewed
Oct 9, 2024
|
Hi @muodov , Sorry for being late. I missed the notification email. I updated the PR based on the feedback and the latest DOM structures. Please, review the PR again when you have a time. |
muodov
reviewed
Oct 21, 2024
muodov
reviewed
Oct 21, 2024
| "if": { "exists": "div[data-consent-manager-dialog]" }, | ||
| "then": [ | ||
| { | ||
| "click": "div[data-consent-manager-dialog] form button:not([type='submit'])" |
There was a problem hiding this comment.
In my testing, pressing this button was not enough because it triggers another dialog. We should probably actually click the radio buttons in the dialog, rejecting the individual categories, and then click "Save"
There was a problem hiding this comment.
I made some changes by manually referencing the DOM but I wasn't able to get the popup on my side again. Thus, I put another conditional step after all to handle the options popup. If you're able to see it, can you try to test it on your side?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs ghostery/broken-page-reports#851
refs ghostery/broken-page-reports#847
refs ghostery/broken-page-reports#848
refs ghostery/broken-page-reports#166
refs ghostery/broken-page-reports#203