Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress that aims to support more filters.
My first goal is to support the
IN
but I'll likely need to support more I'm not sure exactly what theExpressionClass
I'm supporting exactly contains.@Mytherin, few questions to move forward:
vector<unique_ptr<Expression>>
inMySQLBindData
instead ofinput.filters
fromTableFunctionInitInput &input
the right approach? Won't I run in a side effect or anything else?vector<unique_ptr<Expression>>
to avector<unique_ptr<TableFilter>> &filters
or should I update all the filter pushdown logic to supportvector<unique_ptr<Expression>>
instead?Thanks!