Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP complex filter pushdown #10

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kayrnt
Copy link
Contributor

@Kayrnt Kayrnt commented Nov 12, 2023

This is a work in progress that aims to support more filters.
My first goal is to support the IN but I'll likely need to support more I'm not sure exactly what the ExpressionClass I'm supporting exactly contains.

@Mytherin, few questions to move forward:

  • Is adding a vector<unique_ptr<Expression>> in MySQLBindData instead of input.filters from TableFunctionInitInput &input the right approach? Won't I run in a side effect or anything else?
  • Should I figure out how to move from a vector<unique_ptr<Expression>> to a vector<unique_ptr<TableFilter>> &filters or should I update all the filter pushdown logic to support vector<unique_ptr<Expression>> instead?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant