9-lighten_and_standalone #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now this can be executed as a standalone script, not dependant on Lieutenant Planckster anymore - Uses environment variables to setup: kernel_planckster_gateway, minio_repository (if protocol is s3), and the telegram client - The telegram client now only asks for the code sent to your phone (if using phone + password authentication) - Renamed the test minio docker compose file for clarity
- Now installs requirements first before copying the rest of the code, so if you're building many times (e.g., to test), building takes less time - Renamed workdir to "/app"
alebg
force-pushed
the
9-lighten_and_standalone
branch
2 times, most recently
from
bd89951
to
4a0eac8
Compare
- TODO: the instruction '--net="host"' in the docker run command is not acceptable, we need to find a different solution to have the script connect to the host machine's services when running from within a container
alebg
force-pushed
the
9-lighten_and_standalone
branch
from
d9f182f
to
eb28e0e
Compare
- Naming - Arguments are now checked before clients and gateways are instantiated - Updated readme
maany
approved these changes
Mar 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9
But see #13 on the dockerization