Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

545 debug imagecomparison #546

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

545 debug imagecomparison #546

wants to merge 2 commits into from

Conversation

tyBouch
Copy link
Collaborator

@tyBouch tyBouch commented May 4, 2023

No description provided.

@tbouchardMetabolon
Added debug code that writes expected and actual in addition to compa…
bd53ac4 
…rison for debugging and image replacement purposes.

Flag is "debug" which will support values "true" and "false".
@tbouchardMetabolon
Moved the debug code to the outside of the match check. This way it w…
ab1f471 
…ill always occur. Changed configuration to use toBoolean to handle the boolean conversion in the Configuration class.
@tyBouch tyBouch requested a review from dougnoel as a code owner May 4, 2023 17:13
@tyBouch tyBouch self-assigned this May 4, 2023
@tyBouch tyBouch requested a review from sampacos as a code owner May 4, 2023 17:13
@tyBouch tyBouch linked an issue May 4, 2023 that may be closed by this pull request
A debug flag should be settable for image comparison #545
Open
@tyBouch tyBouch requested a review from pturchinetz as a code owner May 4, 2023 17:13
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

84.8% 84.8% Coverage
0.0% 0.0% Duplication

@tyBouch tyBouch marked this pull request as draft June 9, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougnoel dougnoel Awaiting requested review from dougnoel dougnoel is a code owner

@sampacos sampacos Awaiting requested review from sampacos sampacos is a code owner

@pturchinetz pturchinetz Awaiting requested review from pturchinetz pturchinetz is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@tyBouch tyBouch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A debug flag should be settable for image comparison
2 participants
@tyBouch @tbouchardMetabolon