Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[release/7.0.4xx] Update dependencies from dotnet/templating" #40146

Conversation

MiYanni
Copy link
Member

@MiYanni MiYanni commented Apr 11, 2024

Reverts #39705

Summary

I believe this change caused this issue and want to see if this build passes with this... revert-ion? That's not a word. Whatever.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 11, 2024
@MiYanni
Copy link
Member Author

MiYanni commented Apr 12, 2024

The template engine jobs passed, which does seem to indicate that the original PR was the problem.

@baronfel
Copy link
Member

Mind-boggling. The only changes I see in #39705 are arcade/pipeline-related changes, so what could have caused this?

@MiYanni
Copy link
Member Author

MiYanni commented Apr 12, 2024

@baronfel

Mind-boggling. The only changes I see in #39705 are arcade/pipeline-related changes, so what could have caused this?

Here's the more confusing part. In this PR for main, you'll see that multiple commits were failing with this same issue. But the last commit fixed it... which means that there's something being merged into Templating, and that last change to Templating fixed the problem. Whatever that change was (could be Arcade related) had a fix that was merged into Templating main but wasn't for the 7.0.4xx branch. I know there were multiple smaller fixes in Arcade as fallout from the 1ES stuff. But I'm surprised that would affect the tests like this...

@MiYanni
Copy link
Member Author

MiYanni commented Apr 12, 2024

Huh. Reverting causes some Framework tests to fail. 😵

@MiYanni
Copy link
Member Author

MiYanni commented Apr 12, 2024

Good news: Looks like this framework failure exists on other PRs too, so it isn't unique to this revert. That also means that it is still likely Templating is causing the failure for the Templating pipeline tests.
Bad news: Now there is a framework failure causing other PRs to fail. 😵

@v-wuzhai
Copy link
Member

It seems that the new code flow has resolved the templates test failure in #40040, so I will close this.

@v-wuzhai v-wuzhai closed this Apr 15, 2024
@marcpopMSFT marcpopMSFT deleted the revert-39705-darc-release/7.0.4xx-f22dbcd0-3644-4998-9da8-4bf063b02c27 branch June 7, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants