Add package for consuming Blazor framework assets #58721
Conversation
dotnet-issue-labeler
bot
added
the
area-blazor
Haven't looked at the PR yet, but we should probably name it in a way that is related to the framework reference and include It might also be interesting if we find a way of precluding explicit consumption through a package reference (we can have MSBuild logic to potentially detect that scenario). |
| <!-- The package doesn't produce any lib or ref assemblies --> | ||
| <NoWarn>$(NoWarn);NU5128</NoWarn> | ||
|
|
||
| <StaticWebAssetBasePath>_framework</StaticWebAssetBasePath> |
There was a problem hiding this comment.
We should not set the base path to _framework it should be / and the relative paths on the assets to include _framework.
There was a problem hiding this comment.
Actually, this should be $(StaticWebAsetBasePath), if the user sets the base path in their project, the assets should be located in their app base path, not anywhere else.
There was a problem hiding this comment.
Would this require that we move most of the static web asset generation into the build/*.targets file so we get insight into the props of the consuming project? Or is there another way you had in mind that we'd achieve this?
There was a problem hiding this comment.
We don't really need to move the logic there, we can "escape" the value so that it ends up as $(StaticWebAsetBasePath) in the file.
Same with the $(SourceId), we can use escaping for now
| <Description>ASP.NET Core static framework assets</Description> | ||
| <PackageId>Microsoft.AspNetCore.Assets.Pack</PackageId> | ||
| <IsPackable>true</IsPackable> | ||
| <OutputType>Library</OutputType> |
There was a problem hiding this comment.
Why not? This is not producing any exe/dll
There was a problem hiding this comment.
Wanted to make sure it's intentional, I don't know off the top of my head if this controls any behavior we care about
There was a problem hiding this comment.
No, it's conceptually a library
MackinnonBuck
force-pushed
the
mbuck/js-assets-package
branch
from
d65dd82
to
fa5f52d
Compare
Adds a new package
Microsoft.AspNetCore.Assets.Pack(final package name open for discussion), which includes Blazor framework files as static web assets. A follow-up change in the SDK will add an implicit reference to this package in any Blazor project targeting .NET 10 or later.This change means that
blazor.*.jsfiles will get compressed and fingerprinted automatically.Fixes #58783