chore(edit-ema) no call to verify experiment if the id is undefined #30676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This pull request includes several updates to the
DotExperimentsService
and its related test files to improve error handling and testing capabilities. Additionally, it includes minor code cleanup in thewithLoad.ts
file.Improvements to
DotExperimentsService
:core-web/libs/data-access/src/lib/dot-experiments/dot-experiments.service.ts
: Updated thegetById
method to handleundefined
experiment IDs and to return anObservable
ofundefined
in case of errors. [1] [2]Enhancements to testing:
core-web/libs/data-access/src/lib/dot-experiments/dot-experiments.service.spec.ts
: Added imports forHttpClientTestingModule
andHttpTestingController
, and updated the test setup to useTestBed
for dependency injection. Added a new test case to handleundefined
experiment IDs. [1] [2] [3]Code cleanup:
core-web/libs/portlets/edit-ema/portlet/src/lib/store/features/load/withLoad.ts
: Reorganized import statements to follow a consistent order and removed unnecessarycatchError
in theexperiment
observable. [1] [2]Checklist
This PR fixes: #30652