Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(edit-ema) no call to verify experiment if the id is undefined #30676

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

oidacra
Copy link
Member

@oidacra oidacra commented Nov 15, 2024

Proposed Changes

This pull request includes several updates to the DotExperimentsService and its related test files to improve error handling and testing capabilities. Additionally, it includes minor code cleanup in the withLoad.ts file.

Improvements to DotExperimentsService:

Enhancements to testing:

Code cleanup:

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

This PR fixes: #30652

@oidacra oidacra added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit 52a1ac9 Nov 15, 2024
22 checks passed
@oidacra oidacra deleted the 30652-avoid-call-endpoint-undefined-experiment branch November 15, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle undefined experiment ID and error cases in Experiment service endpoint
3 participants