-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(UVE): Bring back inline editing for block editor fields in Headless #30638
Merged
rjvelazco
merged 12 commits into
main
from
issue-30607-uve-bring-back-inline-editing-for-block-editor-fields-in-headless
Nov 18, 2024
Merged
feat(UVE): Bring back inline editing for block editor fields in Headless #30638
rjvelazco
merged 12 commits into
main
from
issue-30607-uve-bring-back-inline-editing-for-block-editor-fields-in-headless
Nov 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjvelazco
changed the title
chore(SDK React): bring Inline Editing for Block Editor
feat(UVE): Bring back inline editing for block editor fields in Headless
Nov 12, 2024
…ops when editable is true
rjvelazco
requested review from
fmontes,
zJaaal,
KevinDavilaDotCMS,
oidacra,
nicobytes and
hmoreras
and removed request for
fmontes and
zJaaal
November 14, 2024 18:01
zJaaal
reviewed
Nov 14, 2024
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Show resolved
Hide resolved
zJaaal
previously requested changes
Nov 14, 2024
core-web/libs/sdk/react/src/lib/components/BlockEditorRenderer/BlockEditorRenderer.tsx
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
zJaaal
approved these changes
Nov 15, 2024
KevinDavilaDotCMS
approved these changes
Nov 18, 2024
rjvelazco
deleted the
issue-30607-uve-bring-back-inline-editing-for-block-editor-fields-in-headless
branch
November 18, 2024 17:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant changes to the inline editing functionality within the
core-web
library, primarily focusing on the block editor and WYSIWYG editor integration. The updates include modifications to the event handling, data structures, and messaging between components. Below are the most important changes grouped by theme:Inline Editing Event Handling:
#handleInlineEditingEvent
method inEditEmaEditorComponent
to handle different types of inline editing events, such asBLOCK_EDITOR
andWYSIWYG
. This method checks for enterprise licenses and handles the event accordingly.CLIENT_ACTIONS
enum to removeINIT_BLOCK_EDITOR_INLINE_EDITING
and addedINIT_INLINE_EDITING
to streamline the event handling process.Data Structure Updates:
InlineEventData
interface to replaceblockEditorContent
with a structuredcontent
object indot-block-editor-sidebar.component.ts
. This change ensures that the content data is more organized and easier to manage.BlockEditorData
interface to include aJSONContent
type for thecontent
field, enhancing the data consistency and type safety.Messaging and Communication:
initInlineEditing
function to send messages to the editor with the appropriate payload for bothBLOCK_EDITOR
andWYSIWYG
types. This change standardizes the communication between the client and the editor.initInlineEditing
function to ensure it sends the correct messages based on the provided type and data.Component and Service Adjustments:
#getJsonContent
method fromDotBlockEditorSidebarComponent
as it is no longer needed with the updatedcontent
handling.InlineEditService
to use the newCLIENT_ACTIONS.INIT_INLINE_EDITING
action, ensuring consistent event handling across the application.Test Updates:
Headless
issue-30607-uve-bring-back-inline-editing-for-block-editor-fields-in-headless.mov
Traditional
issue-30607-uve-bring-back-inline-editing-for-block-editor-fields-in-traditional.mov
WYSIWYG
issue-30607-uve-bring-back-inline-editing-for-block-editor-fields-in-wysiwyg.mov
This PR fixes: #30607