Fix: first Step #30613
Draft
Fix: first Step #30613
+449
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t the second Block Editor level is always just the Identifier
dsilvam
reviewed
Nov 12, 2024
| if (null != httpRequest && null == httpRequest.getAttribute(WebKeys.HTMLPAGE_DEPTH)) { | ||
| httpRequest.setAttribute(WebKeys.HTMLPAGE_DEPTH, MAX_RELATIONSHIP_DEPTH.get()); | ||
|
|
||
| final int beginningDepthValue = getBeginningDepthValue(); |
There was a problem hiding this comment.
rename to "initialDepthValue"
dsilvam
reviewed
Nov 12, 2024
| return depthValue; | ||
| } | ||
|
|
||
| public int getBeginningDepthValue(){ |
There was a problem hiding this comment.
rename to getInitialDepthValue()
jdotcms
approved these changes
Nov 12, 2024
…en-combined-with-relationship-field
…-with-relationship-field' of https://github.com/dotCMS/core into issue-30609-Storyblock-infinite-recursion-when-combined-with-relationship-field
…en-combined-with-relationship-field
…-with-relationship-field' of https://github.com/dotCMS/core into issue-30609-Storyblock-infinite-recursion-when-combined-with-relationship-field
…en-combined-with-relationship-field
|
…-with-relationship-field' of https://github.com/dotCMS/core into issue-30609-Storyblock-infinite-recursion-when-combined-with-relationship-field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
https://github.com/dotCMS/core/pull/30613/files#diff-a44ca86884cbc5b4cbfefc706c1ba39891814a72c266937f621ef70f231abb34L89
https://github.com/dotCMS/core/pull/30613/files#diff-a44ca86884cbc5b4cbfefc706c1ba39891814a72c266937f621ef70f231abb34R359-R365
https://github.com/dotCMS/core/pull/30613/files#diff-8120c6eddd966c9d6be3ee4dbc5af4a94bea9946b0627eb49991dde286610e49R791-R802
https://github.com/dotCMS/core/pull/30613/files#diff-95c4fca870c194a8a966d4063a39779340be2a09ccefce38ab560be274076b2fR599
https://github.com/dotCMS/core/pull/30613/files#diff-95c4fca870c194a8a966d4063a39779340be2a09ccefce38ab560be274076b2fR1303