feat: show Block Editor Side on Traditional #30585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmontes
requested changes
Nov 7, 2024
...ma/portlet/src/lib/components/dot-block-editor-editing/dot-block-editor-sidebar.component.ts
Outdated
Show resolved
Hide resolved
core-web/libs/portlets/edit-ema/portlet/src/lib/services/inline-edit/inline-edit.service.ts
Outdated
Show resolved
Hide resolved
rjvelazco
requested review from
fmontes,
oidacra,
nicobytes,
hmoreras,
zJaaal and
KevinDavilaDotCMS
…r-block-editor-fields
…iting without a lincese
…r-block-editor-fields
…tor-fields' of https://github.com/dotCMS/core into issue-28198-uve-bring-back-inline-editing-for-block-editor-fields
fmontes
approved these changes
Nov 11, 2024
KevinDavilaDotCMS
approved these changes
Nov 11, 2024
zJaaal
requested changes
Nov 11, 2024
core-web/libs/portlets/edit-ema/portlet/src/lib/edit-ema-editor/edit-ema-editor.component.ts
Outdated
Show resolved
Hide resolved
zJaaal
approved these changes
Nov 11, 2024
…r-block-editor-fields
…r-block-editor-fields
|
oidacra
approved these changes
Nov 12, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
rjvelazco
deleted the
issue-28198-uve-bring-back-inline-editing-for-block-editor-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to enhance the block editor functionality and improve the workflow actions in the
core-webproject. The most important changes include the addition of a new block editor sidebar component, updates to the workflow actions service, and modifications to the event handling and test cases.Enhancements to Block Editor Functionality:
DotBlockEditorSidebarComponentwith its HTML, SCSS, and TypeScript files to handle the block editor sidebar functionality. This component includes methods for saving editor changes, closing the sidebar, and handling events. [1] [2] [3]edit-ema-editor.component.htmlto include the new block editor sidebar component and handle theonSavedevent to reload the store.Improvements to Workflow Actions Service:
dot-workflow-actions-fire.service.tsto use URLSearchParams for appending query parameters and refactored the handling ofinodeandindexPolicy.dot-workflow-actions-fire.service.spec.tsto reflect changes in the workflow actions fire service and ensure proper handling of theindexPolicyparameter. [1] [2] [3] [4]Event Handling and Test Cases:
dot-events.service.tsto cast the filtered observable asObservable<DotEvent<T>>.DotBlockEditorSidebarComponentto ensure correct behavior of the sidebar, block editor inputs, save functionality, and error handling.edit-ema-editor.component.spec.tsto include the new block editor sidebar component and handle the inline edit block editor event. [1] [2] [3]Minor Changes:
dot-edit-content-html.service.ts.Video
issue-28198-uve-bring-back-inline-editing-for-block-editor-fields.mov
Handle Error
error.mov
This PR fixes: #28198