Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 30468 remove calls to elastic read only command and disable es read only monitor job #30471

Merged
merged 21 commits into from
Nov 1, 2024
Merged

Issue 30468 remove calls to elastic read only command and disable es read only monitor job #30471

merged 21 commits into from
Nov 1, 2024

Conversation

freddyDOTCMS
Copy link
Contributor

@freddyDOTCMS freddyDOTCMS commented Oct 28, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Remove all the Used of the ES Read Only Monitor, we still are not removing all the logic

This PR fixes: #30468

@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Open
wezell
wezell approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@wezell wezell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we remove the elasticReadOnlyCommand class? Did we get all the cases?

@freddyDOTCMS
Copy link
Contributor Author

Looks good. Should we remove the elasticReadOnlyCommand class? Did we get all the cases?

I think is better later to remove everything

@freddyDOTCMS freddyDOTCMS marked this pull request as ready for review October 28, 2024 18:33
@wezell
Copy link
Contributor

wezell commented Oct 28, 2024

Looks good. Should we remove the elasticReadOnlyCommand class? Did we get all the cases?

I think is better later to remove everything

aka - never 😛

freddyDOTCMS and others added 4 commits October 29, 2024 09:26
@freddyDOTCMS
Making sonnar happy
da4146e
@freddyDOTCMS
Merge branch 'issue-30468-Remove-calls-to-ElasticReadOnlyCommand-and-…
176d082 
…disable-EsReadOnlyMonitorJob' of https://github.com/dotCMS/core into issue-30468-Remove-calls-to-ElasticReadOnlyCommand-and-disable-EsReadOnlyMonitorJob
@freddyDOTCMS
Merge remote-tracking branch 'origin/main' into issue-30468-Remove-ca…
e6f0696 
…lls-to-ElasticReadOnlyCommand-and-disable-EsReadOnlyMonitorJob
@freddyDOTCMS
Merge branch 'main' into issue-30468-Remove-calls-to-ElasticReadOnlyC…
6ef38bc 
…ommand-and-disable-EsReadOnlyMonitorJob
@freddyDOTCMS freddyDOTCMS marked this pull request as draft October 29, 2024 21:39
@freddyDOTCMS freddyDOTCMS mentioned this pull request Oct 29, 2024
Closed
@freddyDOTCMS freddyDOTCMS marked this pull request as ready for review October 31, 2024 22:12
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
3 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@freddyDOTCMS freddyDOTCMS added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit 1bbd500 Nov 1, 2024
35 checks passed
@freddyDOTCMS freddyDOTCMS deleted the issue-30468-Remove-calls-to-ElasticReadOnlyCommand-and-disable-EsReadOnlyMonitorJob branch November 1, 2024 00:43
dsolistorres pushed a commit that referenced this pull request Nov 5, 2024
@freddyDOTCMS @wezell @dsolistorres
Issue 30468 remove calls to elastic read only command and disable es …
d3b8f06 
…read only monitor job (#30471)

### Proposed Changes
* Remove all the Used of the ES Read Only Monitor, we still are not
removing all the logic

---------

Co-authored-by: Will Ezell <[email protected]>
spbolton pushed a commit that referenced this pull request Nov 11, 2024
@freddyDOTCMS @wezell @spbolton
Issue 30468 remove calls to elastic read only command and disable es …
e1f08b7 
…read only monitor job (#30471)

### Proposed Changes
* Remove all the Used of the ES Read Only Monitor, we still are not
removing all the logic

---------

Co-authored-by: Will Ezell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdotcms jdotcms jdotcms approved these changes

@jcastro-dotcms jcastro-dotcms jcastro-dotcms approved these changes

@wezell wezell wezell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove calls to ElasticReadOnlyCommand and disable EsReadOnlyMonitorJob
4 participants
@freddyDOTCMS @wezell @jcastro-dotcms @jdotcms